refactor: use SlotObserver for card slot content detection #11209
Open
web-padawan wants to merge 1 commit intomainfrom
Open
refactor: use SlotObserver for card slot content detection #11209web-padawan wants to merge 1 commit intomainfrom
web-padawan wants to merge 1 commit intomainfrom
Conversation
web-padawan
force-pushed
the
fix/card-observers
branch
from
f6b616f to
5925714
Compare
Replace the blanket slotchange listener and querySelector-based detection with individual SlotObserver instances per slot. Introduce CardSlotObserver helper that extends SlotObserver to toggle host attributes based on slotted content presence, filtering out empty text nodes and shadow DOM fallback content. Add snapshot test for text node content in the default slot. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
web-padawan
force-pushed
the
fix/card-observers
branch
from
5925714 to
97b2978
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on #11208
Fixes #11207
Updated
vaadin-cardto useSlotObserverinstead ofslotchangeevent andquerySelector()calls.Type of change